All files / items update.js

96.82% Statements 61/63
87.09% Branches 27/31
66.66% Functions 2/3
98.33% Lines 59/60

Press n or j to go to the next uncovered block, b, p or k for the previous block.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 2081x           1x 1x 1x   1x 1x   1x 20x 20x 20x 20x 19x   19x 1x                   18x 2x                     16x             15x 1x                     14x 1x                     13x           13x     13x 13x 5x 2x 2x 2x                   2x 2x 1x                     12x 4x                 4x 1x                               11x 11x 11x   11x 11x   18x 5x   13x 13x 13x 13x 13x 13x     11x 1x                   10x 10x 10x   10x                     10x                 2x 2x                       1x      
const { DynamoDBClient } = require('@aws-sdk/client-dynamodb')
const {
  DynamoDBDocumentClient,
  GetCommand,
  UpdateCommand,
  QueryCommand
} = require('@aws-sdk/lib-dynamodb')
const { requirePermission } = require('../utils/requirePermission')
const { validateFieldReference } = require('./reference-validation')
 
const client = new DynamoDBClient({})
const docClient = DynamoDBDocumentClient.from(client)
 
const updateItemHandler = async (event) => {
  try {
    const entityId = event.pathParameters?.entityId
    const id = event.pathParameters?.itemId
    const body = JSON.parse(event.body || '{}')
    const flowId = event.requestContext?.authorizer?.claims?.['custom:flowId']
 
    if (!flowId) {
      return {
        statusCode: 401,
        headers: {
          'Content-Type': 'application/json',
          'Access-Control-Allow-Origin': '*'
        },
        body: JSON.stringify({ error: 'Missing flow context' })
      }
    }
 
    if (!entityId || !id) {
      return {
        statusCode: 400,
        headers: {
          'Content-Type': 'application/json',
          'Access-Control-Allow-Origin': '*'
        },
        body: JSON.stringify({ error: 'Missing entityId or id' })
      }
    }
 
    // Verify item exists and ownership
    const result = await docClient.send(
      new GetCommand({
        TableName: process.env.TABLE_NAME,
        Key: { entityId, id }
      })
    )
 
    if (!result.Item) {
      return {
        statusCode: 404,
        headers: {
          'Content-Type': 'application/json',
          'Access-Control-Allow-Origin': '*'
        },
        body: JSON.stringify({ error: 'Item not found' })
      }
    }
 
    // Only owner flow can update
    if (result.Item.flowId !== flowId) {
      return {
        statusCode: 403,
        headers: {
          'Content-Type': 'application/json',
          'Access-Control-Allow-Origin': '*'
        },
        body: JSON.stringify({ error: 'Access denied - only owner can update' })
      }
    }
 
    // Fetch entity to get field definitions for uniqueness validation
    const entityResult = await docClient.send(
      new GetCommand({
        TableName: process.env.ENTITIES_TABLE_NAME,
        Key: { id: entityId }
      })
    )
    const fields = entityResult.Item?.fields || []
 
    // Check uniqueness for fields with unique: true (exclude current item)
    const data = body.data || {}
    for (const field of fields) {
      if (!field.unique) continue
      const value = data[field.fieldId]
      Iif (value === undefined || value === null || value === '') continue
      const existing = await docClient.send(
        new QueryCommand({
          TableName: process.env.TABLE_NAME,
          KeyConditionExpression: 'entityId = :eid',
          FilterExpression: '#fieldId = :fieldValue',
          ExpressionAttributeNames: { '#fieldId': field.fieldId },
          ExpressionAttributeValues: { ':eid': entityId, ':fieldValue': value }
        })
      )
      // Exclude the current item from the conflict check (sort key cannot appear in FilterExpression)
      const conflict = existing.Items?.some((item) => item.id !== id)
      if (conflict) {
        return {
          statusCode: 400,
          headers: {
            'Content-Type': 'application/json',
            'Access-Control-Allow-Origin': '*'
          },
          body: JSON.stringify({ error: 'UNIQUE_FIELD_CONFLICT', fieldId: field.fieldId })
        }
      }
    }
 
    for (const field of fields) {
      const referenceCheck = await validateFieldReference({
        docClient,
        field,
        value: data[field.fieldId],
        flowId,
        flowMembershipsTableName: process.env.FLOW_MEMBERSHIPS_TABLE_NAME,
        itemsTableName: process.env.TABLE_NAME
      })
 
      if (!referenceCheck.valid) {
        return {
          statusCode: 400,
          headers: {
            'Content-Type': 'application/json',
            'Access-Control-Allow-Origin': '*'
          },
          body: JSON.stringify({
            error: referenceCheck.error,
            fieldId: referenceCheck.fieldId,
            referenceType: referenceCheck.referenceType
          })
        }
      }
    }
 
    // Build update expression from body.data
    const updateExpressions = []
    const expressionAttributeNames = {}
    const expressionAttributeValues = {}
 
    let attrIndex = 0
    for (const [key, value] of Object.entries(data)) {
      // Skip reserved and auto-managed fields (updatedAt is hardcoded below)
      if (['entityId', 'id', 'flowId', 'createdBy', 'createdAt', 'updatedAt'].includes(key)) {
        continue
      }
      const nameKey = `#attr${attrIndex}`
      const valueKey = `:val${attrIndex}`
      updateExpressions.push(`${nameKey} = ${valueKey}`)
      expressionAttributeNames[nameKey] = key
      expressionAttributeValues[valueKey] = value
      attrIndex++
    }
 
    if (updateExpressions.length === 0) {
      return {
        statusCode: 400,
        headers: {
          'Content-Type': 'application/json',
          'Access-Control-Allow-Origin': '*'
        },
        body: JSON.stringify({ error: 'No fields to update' })
      }
    }
 
    updateExpressions.push('#updatedAt = :updatedAt')
    expressionAttributeNames['#updatedAt'] = 'updatedAt'
    expressionAttributeValues[':updatedAt'] = new Date().toISOString()
 
    const updateResult = await docClient.send(
      new UpdateCommand({
        TableName: process.env.TABLE_NAME,
        Key: { entityId, id },
        UpdateExpression: 'SET ' + updateExpressions.join(', '),
        ExpressionAttributeNames: expressionAttributeNames,
        ExpressionAttributeValues: expressionAttributeValues,
        ReturnValues: 'ALL_NEW'
      })
    )
 
    return {
      statusCode: 200,
      headers: {
        'Content-Type': 'application/json',
        'Access-Control-Allow-Origin': '*'
      },
      body: JSON.stringify(updateResult.Attributes)
    }
  } catch (error) {
    console.error('Error:', error)
    return {
      statusCode: 500,
      headers: {
        'Content-Type': 'application/json',
        'Access-Control-Allow-Origin': '*'
      },
      body: JSON.stringify({ error: 'Failed to update item' })
    }
  }
}
 
// Wrap with permission check: require 'items:{itemId}:update' permission
exports.handler = requirePermission(updateItemHandler, {
  permission: (event) => `items:${event.pathParameters?.itemId}:update`
})